Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nr2.0: Resolve type aliases inside trait definitions #3330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nr2.0: Resolve type aliases inside trait definitions #3330

wants to merge 1 commit into from
+10 −5

Conversation

powerboat9
Copy link
Contributor

Requires #3323

@powerboat9 powerboat9 mentioned this pull request Dec 28, 2024
Open
CohenArthur
CohenArthur approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@CohenArthur CohenArthur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question but happy to merge

gcc/rust/resolve/rust-late-name-resolver-2.0.cc Outdated Show resolved Hide resolved
@powerboat9
nr2.0: Resolve type aliases inside trait definitions
5b35fc7 
gcc/rust/ChangeLog:

	* resolve/rust-toplevel-name-resolver-2.0.cc
	(TopLevel::visit): Add visitor for TraitItemType.
	* resolve/rust-toplevel-name-resolver-2.0.h
	(TopLevel::visit): Likewise.

gcc/testsuite/ChangeLog:

	* rust/compile/nr2/exclude: Remove entries.

Signed-off-by: Owen Avery <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenArthur CohenArthur CohenArthur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@powerboat9 @CohenArthur